Stop publishing nightly and master container images - #512
Merged
Conversation
Remove the nightly cron and the push-on-master trigger from the Docker workflow so only semver tags publish to ghcr.io. Guard the image push on tag refs so a manual dispatch on a branch cannot publish a branch-named image. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JbjzuSab2kesaLAq9wbw2B
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The workflow still appears to be able to publish to GHCR on non-tag runs via the :latest retag logic, which conflicts with the PR description’s “only semver tag pushes publish” guarantee.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the Docker publishing GitHub Actions workflow to stop producing “nightly” and “master”-triggered container images, shifting publishing to semver tag-driven releases while keeping PR builds.
Changes:
- Removed the scheduled (cron) trigger for nightly publishing.
- Removed the push-on-
mastertrigger so non-tag commits no longer publish images. - Updated the Buildx step to only push images when the ref is a tag (
github.ref_type == 'tag').
File summaries
| File | Description |
|---|---|
| .github/workflows/docker-publish.yml | Removes cron/master publish triggers and gates image pushing to tag refs only. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| with: | ||
| context: . | ||
| push: ${{ github.event_name != 'pull_request' }} | ||
| push: ${{ github.ref_type == 'tag' }} |
A branch workflow_dispatch could still re-point :latest through the release lookup fallback. Run the login and the retag only on tag refs and use the pushed tag name directly. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JbjzuSab2kesaLAq9wbw2B
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workflow_dispatchon a branch builds but does not publish a branch-named image.:latestretag of the newest release are unchanged.The existing
nightlyandmasterimages on ghcr.io are being removed separately. Until this merges, the cron on master keeps running and can recreate them.🤖 Generated with Claude Code
https://claude.ai/code/session_01JbjzuSab2kesaLAq9wbw2B